Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add option to process single or multiple tab for better performance #136

Merged
merged 15 commits into from
Sep 8, 2023

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Sep 8, 2023

Description

This PR includes some refactoring to the single-tab-processing feature, fixes to some issues which were introduced there and adds some relevant test coverage.

Relevant Technical Choices

  • Used chrome.devtools.inspectedWindow.eval instead of chrome.tabs.query to get the site URL.
  • Added a loader to the DevTools which fixes the flash of the Analyze the tab screen.

Testing Instructions

  • Open the terminal and run npm I && npm run dev.
  • Open any site and go to Privacy Sandbox in DevTools you should first see a loader for a brief period of time then see the cookies landing page.
  • The problem of `First Party cookies not found should not persist for long anymore.

@amovar18 amovar18 marked this pull request as ready for review September 8, 2023 13:33
@mohdsayed mohdsayed merged commit e1f7648 into develop Sep 8, 2023
@mohdsayed mohdsayed deleted the fix/settings-page-single-tab-processing branch September 8, 2023 14:14
@mohdsayed mohdsayed changed the title Refactor: Settings page and single tab processing feature Feature: Settings page and single tab processing feature Sep 8, 2023
@mohdsayed mohdsayed changed the title Feature: Settings page and single tab processing feature Feature: Add option to process single or multiple tab for better performance Sep 8, 2023
@mohdsayed mohdsayed mentioned this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants